Skip to content

Use Spans to identify unreachable subpatterns in or-patterns #73973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2020
Merged

Use Spans to identify unreachable subpatterns in or-patterns #73973

merged 2 commits into from
Jul 6, 2020

Conversation

Nadrieril
Copy link
Member

@Nadrieril Nadrieril commented Jul 2, 2020 •
edited by Manishearth
Loading

Fixes #71977

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2020
teymour-aldridge
teymour-aldridge reviewed Jul 3, 2020
View reviewed changes
@matthewjasper
Copy link
Contributor

Can you remove the allow(unreachable_patterns) from src/test/ui/or-patterns/search-via-bindings.rs?

@Nadrieril
Copy link
Member Author

@matthewjasper I removed it and indeed it's not needed anymore

@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 5, 2020

📌 Commit 3cb31b6 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2020
@bors
Copy link
Collaborator

bors commented Jul 5, 2020

⌛ Testing commit 3cb31b6 with merge 4bd2a8914cfe1951dbb719ebb06b073d58ebf0d0...

@bors
Copy link
Collaborator

bors commented Jul 5, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 5, 2020
@JohnTitor
Copy link
Member

@bors retry #71988

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2020
@Manishearth Manishearth changed the title Fix #71977 Use Spans to identify unreachable subpatterns in or-patterns Jul 5, 2020
@Manishearth
Copy link
Member

Please use descriptive PR titles

@Manishearth Manishearth mentioned this pull request Jul 5, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 5, 2020
@bors
Auto merge of rust-lang#74073 - Manishearth:rollup-faqo9lx, r=Manishe…
0c03aee 
…arth

Rollup of 12 pull requests

Successful merges:

 - rust-lang#72688 (added .collect() into String from Box<str>)
 - rust-lang#73787 (Add unstable docs for rustc_attrs)
 - rust-lang#73834 (Some refactoring around intrinsic type checking)
 - rust-lang#73871 (Fix try_print_visible_def_path for Rust 2018)
 - rust-lang#73937 (Explain exhaustive matching on {usize,isize} maximum values)
 - rust-lang#73973 (Use `Span`s to identify unreachable subpatterns in or-patterns)
 - rust-lang#74000 (add `lazy_normalization_consts` feature gate)
 - rust-lang#74025 (Remove unnecessary release from Arc::try_unwrap)
 - rust-lang#74027 (Convert more `DefId`s to `LocalDefId`s)
 - rust-lang#74055 (Fix spacing in Iterator fold doc)
 - rust-lang#74057 (expected_found `&T` -> `T`)
 - rust-lang#74064 (variant_count: avoid incorrect dummy implementation)

Failed merges:

r? @ghost
@bors bors merged commit e450646 into rust-lang:master Jul 6, 2020
@Nadrieril Nadrieril deleted the fix-71977 branch November 6, 2020 23:41
@Nadrieril Nadrieril added the A-exhaustiveness-checking Relating to exhaustiveness / usefulness checking of patterns label Dec 10, 2023
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@teymour-aldridge teymour-aldridge teymour-aldridge left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@matthewjasper matthewjasper

Labels
A-exhaustiveness-checking Relating to exhaustiveness / usefulness checking of patterns S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

or_patterns: incorrect unreachable pattern warning
8 participants
@Nadrieril @rust-highfive @matthewjasper @bors @JohnTitor @Manishearth @teymour-aldridge @cuviper